Skip to content

Settings page labels lack htmlFor#951

Merged
ogazboiz merged 1 commit into
LabsCrypt:mainfrom
akprinciple:Settings_page_labels_lack_htmlFor
Jul 4, 2026
Merged

Settings page labels lack htmlFor#951
ogazboiz merged 1 commit into
LabsCrypt:mainfrom
akprinciple:Settings_page_labels_lack_htmlFor

Conversation

@akprinciple

Copy link
Copy Markdown
Contributor

Description

closes #630
This PR resolves accessibility (a11y) issues on the Settings page where screen readers are unable to announce which controls the labels belong to. Specifically:

  1. The Default Token select element was not associated with its label.
  2. The Amount Format button group had no label association.
  3. The Decimal Places button group had no label association.

These changes ensure screen readers correctly announce the labels and group context.

@ogazboiz

ogazboiz commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

heads up: main's ci was broken (the Backend CI and Backend Docker Image CI jobs) until the fixes in #969 and #974 just landed, so the red backend/docker checks on this pr are almost certainly stale, they ran against the broken main. please rebase to re-test against the now-green main: git fetch origin && git rebase origin/main && git push --force-with-lease. once it's green i'll review and merge. (if a non-backend check like Frontend CI is still red after the rebase, that part is a real issue worth a look, since frontend ci was passing on main.)

@akprinciple akprinciple force-pushed the Settings_page_labels_lack_htmlFor branch from 8b71fcd to 4d2295c Compare July 1, 2026 14:06
@akprinciple

Copy link
Copy Markdown
Contributor Author

@ogazboiz Done... Thank you for your time. I learnt something new.

@ogazboiz ogazboiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct a11y work, the Default Token select gets a proper htmlFor/id pair, and you correctly used id + role=radiogroup + aria-labelledby for the amount-format/decimals button groups since those aren't real label/input pairs. merging. (non-blocking follow-up: the radios could get role=radio + aria-checked for full group semantics.)

@ogazboiz ogazboiz merged commit 749c9f5 into LabsCrypt:main Jul 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frontend] Settings page labels lack htmlFor — Default Token / Amount Format / Decimal Places

2 participants