Settings page labels lack htmlFor#951
Conversation
|
heads up: main's ci was broken (the Backend CI and Backend Docker Image CI jobs) until the fixes in #969 and #974 just landed, so the red backend/docker checks on this pr are almost certainly stale, they ran against the broken main. please rebase to re-test against the now-green main: |
8b71fcd to
4d2295c
Compare
|
@ogazboiz Done... Thank you for your time. I learnt something new. |
ogazboiz
left a comment
There was a problem hiding this comment.
correct a11y work, the Default Token select gets a proper htmlFor/id pair, and you correctly used id + role=radiogroup + aria-labelledby for the amount-format/decimals button groups since those aren't real label/input pairs. merging. (non-blocking follow-up: the radios could get role=radio + aria-checked for full group semantics.)
Description
closes #630
This PR resolves accessibility (a11y) issues on the Settings page where screen readers are unable to announce which controls the labels belong to. Specifically:
These changes ensure screen readers correctly announce the labels and group context.